-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Tests Refactoring #740
Draft
TimoImhof
wants to merge
25
commits into
adapter-hub:main
Choose a base branch
from
TimoImhof:dev/test-refactoring
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dapters into dev/test-refactoring
- reorder directory structure to separate testing models and adapter methods (needs further refactoring for separating tests that are extecuted for each model vs tests that are just run once) - remove all model tests except albert for now (will be readded once final design is agreed on) - refactor albert adapter test class to group test mixins in categories which are then displayed accordingly by test viewer - adjust imports to reflect new directory structure
- refactor generate_test into base test class and adapt parallel generate test accordingly - refactor lm head selection into own method - create utils file for utility methods and adapt imports accordingly - remove is_speech_model flags - replace redundant attributes and methods - enforce proper method naming conventions
This reverts commit b390d61.
- Re-add bart adapter method tests - Remove duplicate added tests - In conversion test refactor model specific if else statements into model test class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to refactor the test suite into a more generic version.
The following points are to be covered (subject to change; will become more granular):
This should make it easier to add new models or methods to the existing test suite in the future and make the development/testing process more convenient in the future